Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trivial implementation of MockEthProvider for completeness. #4960

Merged

Conversation

PlamenHristov
Copy link
Contributor

@PlamenHristov PlamenHristov commented Oct 9, 2023

Completed trivial implementation of MockEthProvider, given the data model defined, so that it can be used in integration tests.

It's not ideal, but is a good start for whoever wants to expand the data model to accomodate historical blocks

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4960 (40619ad) into main (ee5b8c9) will decrease coverage by 22.63%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/storage/provider/src/test_utils/mock.rs 15.81% <0.00%> (-6.46%) ⬇️

... and 333 files with indirect coverage changes

Flag Coverage Δ
integration-tests ?
unit-tests 44.54% <0.00%> (-18.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 17.53% <ø> (-13.23%) ⬇️
blockchain tree 39.57% <ø> (-41.06%) ⬇️
pipeline 63.17% <ø> (-25.28%) ⬇️
storage (db) 51.06% <0.00%> (-23.35%) ⬇️
trie 62.49% <ø> (-32.03%) ⬇️
txpool 35.46% <ø> (-13.06%) ⬇️
networking 55.20% <ø> (-20.93%) ⬇️
rpc 23.50% <ø> (-34.56%) ⬇️
consensus 50.57% <ø> (-12.45%) ⬇️
revm 21.23% <ø> (-6.57%) ⬇️
payload builder 3.39% <ø> (-4.57%) ⬇️
primitives 62.68% <ø> (-22.76%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's actually quite clever.

this will prevent panics and instead results in None responses if the state functions were to be called

lgtm

@mattsse mattsse added the C-test A change that impacts how or what we test label Oct 9, 2023
@mattsse mattsse added this pull request to the merge queue Oct 9, 2023
Merged via the queue into paradigmxyz:main with commit 450282c Oct 9, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants