Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add some geth tracer ergonomics #4952

Merged
merged 1 commit into from
Oct 8, 2023
Merged

chore: add some geth tracer ergonomics #4952

merged 1 commit into from
Oct 8, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 8, 2023

No description provided.

@mattsse mattsse requested a review from Rjected as a code owner October 8, 2023 17:19
@mattsse mattsse added the A-rpc Related to the RPC implementation label Oct 8, 2023
@mattsse mattsse force-pushed the matt/some-geth-tracer-ergonomics branch from 058e4a7 to 8d1cf02 Compare October 8, 2023 17:20
@mattsse mattsse mentioned this pull request Oct 8, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #4952 (8d1cf02) into main (98bc2b5) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-types/src/eth/trace/geth/call.rs 76.47% <0.00%> (-23.53%) ⬇️
crates/rpc/rpc-types/src/eth/trace/geth/mod.rs 63.08% <0.00%> (-10.36%) ⬇️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.33% <0.00%> (+<0.01%) ⬆️
unit-tests 62.63% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.76% <ø> (ø)
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 48.52% <ø> (ø)
networking 76.11% <ø> (+<0.01%) ⬆️
rpc 58.43% <0.00%> (-0.14%) ⬇️
consensus 63.01% <ø> (+0.11%) ⬆️
revm 28.39% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 85.42% <ø> (ø)

@mattsse mattsse merged commit 18c4891 into main Oct 8, 2023
23 checks passed
@mattsse mattsse deleted the matt/some-geth-tracer-ergonomics branch October 8, 2023 17:37
mattsse added a commit that referenced this pull request Nov 8, 2023
@mattsse
chore: add some geth tracer ergonomics (#4952)
5b5840c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattsse