Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better topic0 #4950

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Better topic0 #4950

merged 3 commits into from
Oct 9, 2023

Conversation

supernovahs
Copy link
Contributor

Ref #4575

@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #4950 (f1a373e) into main (537ad17) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 66.66%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-types/src/eth/filter.rs 77.79% <66.66%> (-0.39%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.34% <0.00%> (+<0.01%) ⬆️
unit-tests 62.65% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.76% <ø> (ø)
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.48% <ø> (-0.04%) ⬇️
txpool 48.98% <ø> (ø)
networking 76.10% <ø> (-0.02%) ⬇️
rpc 58.45% <66.66%> (-0.12%) ⬇️
consensus 63.01% <ø> (ø)
revm 28.46% <ø> (+0.07%) ⬆️
payload builder 7.96% <ø> (ø)
primitives 85.45% <ø> (ø)

mattsse
mattsse approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I kept the topic0 fn but deprecated it, because this would break

@mattsse mattsse enabled auto-merge October 9, 2023 12:30
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Oct 9, 2023
@mattsse mattsse added this pull request to the merge queue Oct 9, 2023
Merged via the queue into paradigmxyz:main with commit 670d459 Oct 9, 2023
23 checks passed
@mattsse mattsse mentioned this pull request Oct 12, 2023
Closed
mattsse added a commit that referenced this pull request Nov 8, 2023
@supernovahs @mattsse
Better topic0 (#4950)
32ac6dd 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @mattsse