feat: Feat/add on rpc server started hook #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
mattsse
approved these changes
Oct 10, 2023
mattsse
added
M-changelog
|
aaa |
mattsse
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!@mattsseI work on #4917
I really need your help!
I prepared a new function, I use the new type RethRpcComponents but I've got a borrowing issue on the line below which I don't know how to resolve in a clear manner YET:
cannot move out ofmodulesbecause it is borrowed move out ofmodulesoccurs hererustc[Click for full compiler diagnostic](rust-analyzer-diagnostics-view:/diagnostic%20message%20%5B0%5D?0#file%3A%2F%2F%2FUsers%2Fnil.medvedev%2FProjects%2Fmy%2Freth%2Fbin%2Freth%2Fsrc%2Fargs%2Frpc_server_args.rs) rpc_server_args.rs(206, 82): borrow ofmodulesoccurs here rpc_server_args.rs(198, 14): bindingmodulesdeclared here rpc_server_args.rs(233, 54): borrow later used herehttps://github.com/allnil/reth/blob/2fc27313e4b2c381514168d2731af20eaa9c3c33/bin/reth/src/args/rpc_server_args.rs#L211C6-L211C6
I played with it in different ways but still don't know how to do it better
I will continue to work on it but maybe you could just give me a hint or show me a direction to proceed?
Thank you!