Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prune): headers segment triggered by snapshots #4936

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Oct 6, 2023

This PR introduces a Headers prune segment which combines the pruning of CanonicalHeaders, Headers and HeaderTD when the snapshot of corresponding tables has been done.

@shekhirin shekhirin added C-enhancement New feature or request A-pruning Related to pruning or full node labels Oct 6, 2023
@shekhirin shekhirin changed the title feat(prune): headers segment feat(prune): headers segment triggered by snapshots Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #4936 (f360968) into main (50fa71d) will decrease coverage by 0.09%.
Report is 11 commits behind head on main.
The diff coverage is 82.98%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/prune/segment.rs 100.00% <ø> (ø)
crates/prune/src/segments/receipts.rs 97.95% <100.00%> (-0.05%) ⬇️
crates/stages/src/test_utils/test_db.rs 85.19% <100.00%> (ø)
crates/prune/src/segments/headers.rs 99.02% <99.02%> (ø)
...torage/provider/src/providers/database/provider.rs 76.75% <95.23%> (+0.01%) ⬆️
crates/prune/src/segments/mod.rs 84.61% <88.46%> (+25.09%) ⬆️
crates/prune/src/pruner.rs 76.84% <9.67%> (-2.23%) ⬇️

... and 31 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.30% <0.00%> (-0.15%) ⬇️
unit-tests 62.67% <82.98%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.76% <ø> (-1.49%) ⬇️
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <100.00%> (ø)
storage (db) 74.41% <95.23%> (-0.03%) ⬇️
trie 94.44% <ø> (-0.04%) ⬇️
txpool 48.52% <ø> (ø)
networking 76.11% <ø> (+0.03%) ⬆️
rpc 58.43% <ø> (+0.74%) ⬆️
consensus 63.01% <ø> (ø)
revm 28.39% <ø> (-0.08%) ⬇️
payload builder 7.96% <ø> (ø)
primitives 85.42% <ø> (ø)

@shekhirin shekhirin marked this pull request as ready for review October 6, 2023 16:49
@shekhirin shekhirin requested review from mattsse and removed request for onbjerg, rakita, gakonst and rkrasiuk October 6, 2023 16:49
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/prune/src/segments/mod.rs Outdated Show resolved Hide resolved
crates/prune/src/segments/mod.rs Outdated Show resolved Hide resolved
@shekhirin shekhirin added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 9ca0cdc Oct 9, 2023
23 checks passed
@shekhirin shekhirin deleted the alexey/prune-headers branch October 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants