Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always serialize zero balance #4929

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: always serialize zero balance #4929

merged 1 commit into from
Oct 6, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 6, 2023

@mattsse mattsse requested a review from Rjected as a code owner October 6, 2023 10:12
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #4929 (72c6a39) into main (50fa71d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
...ates/rpc/rpc-types/src/eth/trace/geth/pre_state.rs 82.14% <0.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.45% <0.00%> (+<0.01%) ⬆️
unit-tests 62.73% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.24% <ø> (ø)
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.43% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 48.98% <ø> (+0.46%) ⬆️
networking 76.09% <ø> (+0.02%) ⬆️
rpc 57.68% <0.00%> (-0.01%) ⬇️
consensus 62.89% <ø> (-0.12%) ⬇️
revm 28.47% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 85.43% <ø> (+<0.01%) ⬆️

@mattsse mattsse requested a review from shekhirin October 6, 2023 10:50
@mattsse mattsse added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 529635f Oct 6, 2023
23 checks passed
@mattsse mattsse deleted the matt/rm-zero-check-for-balance branch October 6, 2023 15:08
mattsse added a commit that referenced this pull request Nov 8, 2023
@mattsse
fix: always serialize zero balance (#4929)
5e8d438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @shekhirin