-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify node components #4922
Simplify node components #4922
Conversation
Codecov Report
... and 26 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fyi @allnil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's great, exactly what we want
30a8cf8
to
2166132
Compare
2166132
to
e96e068
Compare
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Ref #4918
There's a type complexity . Thinking what's the best way to handle it?
Or Ignore , should we choose to accept it.