Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add blob_gas_used after succesful tx execution #4913

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 5, 2023

Previously we were adding blob_gas_used, even if the tx failed execution. This caused incorrect blob gas used returned in built payloads, since the payload would contain fewer blobs. This means a subsequent engine_newPayload would fail.

This makes sure we only add the blob_gas_used if the tx succeeded.

Fixes the hive engine cancun/Blob Transaction Ordering, Single Account tests.

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation A-consensus Related to the consensus engine A-block-building Related to block building C-test A change that impacts how or what we test labels Oct 5, 2023
@Rjected Rjected requested a review from mattsse as a code owner October 5, 2023 03:11
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #4913 (7578c76) into main (066998d) will decrease coverage by 0.04%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/payload/basic/src/lib.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/pending_block.rs 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.48% <0.00%> (-0.02%) ⬇️
unit-tests 62.61% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.63% <ø> (ø)
blockchain tree 80.64% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.30% <ø> (ø)
trie 94.52% <ø> (+0.03%) ⬆️
txpool 48.90% <ø> (-0.20%) ⬇️
networking 76.06% <ø> (-0.08%) ⬇️
rpc 57.71% <0.00%> (-0.01%) ⬇️
consensus 61.05% <ø> (ø)
revm 28.47% <ø> (ø)
payload builder 8.14% <0.00%> (-0.03%) ⬇️
primitives 85.41% <ø> (-0.02%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@mattsse mattsse enabled auto-merge October 5, 2023 10:45
@mattsse mattsse added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 4dceabf Oct 5, 2023
23 checks passed
@mattsse mattsse deleted the dan/add-blob-gas-after-succesful-execution branch October 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants