fix: add blob_gas_used after succesful tx execution #4913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were adding
blob_gas_used
, even if the tx failed execution. This caused incorrect blob gas used returned in built payloads, since the payload would contain fewer blobs. This means a subsequentengine_newPayload
would fail.This makes sure we only add the
blob_gas_used
if the tx succeeded.Fixes the hive engine
cancun/Blob Transaction Ordering, Single Account
tests.