Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually implements arbitrary for TxValue #4907

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Oct 4, 2023

Any test (such as iai bench) that relies on generating arbitrary/proptest TxValue and eventually calls to_compact can currently fail if it generates a U256 bigger than u128.

Until we break the database again and unify the types, we need to manually implement the arbitrary as well.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Oct 4, 2023
@joshieDo joshieDo requested a review from mattsse October 4, 2023 17:58
@joshieDo joshieDo requested a review from gakonst as a code owner October 4, 2023 17:58
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #4907 (109ca9e) into main (1c39b37) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/transaction/tx_value.rs 98.64% <100.00%> (+0.40%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.50% <0.00%> (-0.01%) ⬇️
unit-tests 62.65% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.58% <ø> (ø)
blockchain tree 80.64% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.32% <ø> (ø)
trie 94.52% <ø> (+0.03%) ⬆️
txpool 49.10% <ø> (-0.02%) ⬇️
networking 76.09% <ø> (-0.02%) ⬇️
rpc 57.71% <ø> (-0.04%) ⬇️
consensus 61.05% <ø> (ø)
revm 28.47% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.46% <100.00%> (+0.02%) ⬆️

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattsse mattsse added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit bf7b6f8 Oct 4, 2023
23 checks passed
@mattsse mattsse deleted the joshie/fix-arbitrary-txvalue branch October 4, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants