Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return empty vec if input vec is empty #4906

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 4, 2023

no need to aquire a readlock here

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-tx-pool Related to the transaction mempool labels Oct 4, 2023
@mattsse mattsse force-pushed the matt/add-missing-empty-check4 branch from 2d847b8 to 0c97f77 Compare October 4, 2023 16:50
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #4906 (0c97f77) into main (5f56e52) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

Impacted file tree graph

Files Coverage Δ
crates/transaction-pool/src/pool/mod.rs 50.35% <33.33%> (-0.19%) ⬇️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.50% <0.00%> (-0.01%) ⬇️
unit-tests 62.65% <33.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.58% <ø> (ø)
blockchain tree 80.64% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.32% <ø> (ø)
trie 94.48% <ø> (-0.04%) ⬇️
txpool 49.10% <33.33%> (-0.49%) ⬇️
networking 76.09% <ø> (-0.03%) ⬇️
rpc 57.72% <ø> (ø)
consensus 61.05% <ø> (ø)
revm 28.47% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.43% <ø> (+0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit e93edfc Oct 4, 2023
23 checks passed
@mattsse mattsse deleted the matt/add-missing-empty-check4 branch October 4, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants