Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump revm #4884

Merged
merged 6 commits into from
Oct 3, 2023
Merged

chore: bump revm #4884

merged 6 commits into from
Oct 3, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 3, 2023

This updates the revm version, which now has alloy types. A bug is also fixed in the payload builder where we were initializing the BlobExcessGasAndPrice with the next block's blob fee rather than the next block's excess blob gas.

adds blob fee precision update and fixes builder env bug
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #4884 (17857b0) into main (6f4febc) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 25.00%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/constants/eip4844.rs 93.33% <ø> (ø)
crates/transaction-pool/src/pool/txpool.rs 72.54% <100.00%> (ø)
crates/transaction-pool/src/traits.rs 12.35% <ø> (ø)
crates/payload/builder/src/payload.rs 0.00% <0.00%> (ø)
crates/primitives/src/header.rs 94.75% <0.00%> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.53% <25.00%> (-0.01%) ⬇️
unit-tests 62.57% <25.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.63% <ø> (ø)
blockchain tree 80.44% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.32% <ø> (ø)
trie 94.44% <ø> (-0.04%) ⬇️
txpool 49.63% <100.00%> (+0.45%) ⬆️
networking 76.08% <ø> (-0.03%) ⬇️
rpc 57.72% <ø> (ø)
consensus 61.06% <ø> (ø)
revm 28.54% <ø> (ø)
payload builder 8.16% <0.00%> (ø)
primitives 85.24% <0.00%> (-0.02%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge October 3, 2023 12:26
@mattsse mattsse added this pull request to the merge queue Oct 3, 2023
@rakita rakita removed this pull request from the merge queue due to a manual request Oct 3, 2023
Cargo.toml Outdated Show resolved Hide resolved
@@ -96,8 +96,7 @@ unknown-registry = "warn"
unknown-git = "deny"
allow-git = [
# TODO: remove, see ./Cargo.toml
"https://github.com/Evalir/revm",
# "https://github.com/bluealloy/revm",
"https://github.com/bluealloy/revm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://github.com/bluealloy/revm",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep this, I think we'll have to use via git again eventually

mattsse and others added 2 commits October 3, 2023 15:00
Co-authored-by: rakita <rakita@users.noreply.github.com>
@rakita rakita added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit b1a7a87 Oct 3, 2023
24 checks passed
@rakita rakita deleted the dan/bump-revm branch October 3, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants