Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check active hardforks using head block for validator #4882

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 2, 2023

this should fix the Test: ForkchoiceUpdatedV2 then ForkchoiceUpdatedV3 Valid Payload Building Requests (Cancun) hive test

previously we did not enable cancun by default, only on_new_head event.

this adds a new config function with_head_timestamp that enables cancun/shanghai support based on the head block's timestamp

@mattsse mattsse requested a review from onbjerg as a code owner October 2, 2023 21:46
@mattsse mattsse requested a review from Rjected October 2, 2023 21:47
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-tx-pool Related to the transaction mempool labels Oct 2, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #4882 (28aa7b9) into main (f59db31) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Coverage Δ
bin/reth/src/node/mod.rs 30.42% <100.00%> (+2.88%) ⬆️
crates/transaction-pool/src/validate/eth.rs 8.21% <100.00%> (+1.27%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.50% <0.00%> (-0.01%) ⬇️
unit-tests 62.63% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.63% <100.00%> (+0.35%) ⬆️
blockchain tree 80.44% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.29% <ø> (ø)
trie 94.44% <ø> (-0.08%) ⬇️
txpool 49.63% <100.00%> (+0.02%) ⬆️
networking 76.12% <ø> (-0.05%) ⬇️
rpc 57.78% <ø> (-0.01%) ⬇️
consensus 61.06% <ø> (ø)
revm 28.54% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.27% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 08c5c43 Oct 2, 2023
23 checks passed
@mattsse mattsse deleted the matt/check-head-timestamp-for-pool-validator branch October 2, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants