feat(pruner): shared deletion limit #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 38 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/pruner-deletion-limit
branch
from
66068fd
to
95ea72e
Compare
shekhirin
force-pushed
the
alexey/pruner-deletion-limit
branch
from
95ea72e
to
9d0e897
Compare
shekhirin
requested review from
joshieDo,
rkrasiuk,
mattsse,
Rjected,
rakita,
onbjerg and
gakonst
as code owners
shekhirin
force-pushed
the
alexey/pruner-deletion-limit
branch
3 times, most recently
from
b257d39
to
7268a77
Compare
shekhirin
force-pushed
the
alexey/pruner-deletion-limit
branch
from
7268a77
to
3356ddf
Compare
|
PR itself lgtm. |
joshieDo
reviewed
Oct 4, 2023
joshieDo
approved these changes
Oct 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of headers and transactions pruning for the needs of snapshots, it becomes even harder to manage the batch sizes for pruner, so we both not hit the MDBX freelist issues and still prune the data.
This PR refactors the batch sizes into one shared limit for maximum number of deleted entries per pruner run. Each prune part deletes as much as possible, it decreases the deletion limit, and further parts use new limit. It also means that prune parts now have different priority, because e.g. if receipts, which are pruned first, consume the deletion limit fully, consequent parts won't prune anything.
Tested on both mainnet and sepolia, example log
2023-10-04T18:12:00.521326Z INFO reth::node::events: Pruner finished tip_block_number=4424545 elapsed=899.944121ms parts={SenderRecovery: (Finished, 0), Receipts: (Finished, 0), ContractLogs: (Finished, 2588), AccountHistory: (Finished, 2976), StorageHistory: (Finished, 18652)}