Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to example rpc extension #4872

Merged

Conversation

ckoopmann
Copy link
Contributor

closes #4868

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #4872 (aeeabab) into main (858ea41) will decrease coverage by 51.72%.
The diff coverage is n/a.

❗ Current head aeeabab differs from pull request most recent head 04e995c. Consider uploading reports for the commit 04e995c to get more accurate results

Impacted file tree graph

see 400 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <ø> (-0.01%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 6.31% <ø> (-25.96%) ⬇️
blockchain tree 0.00% <ø> (-80.45%) ⬇️
pipeline 0.00% <ø> (-88.46%) ⬇️
storage (db) 16.40% <ø> (-56.90%) ⬇️
trie 0.00% <ø> (-94.53%) ⬇️
txpool 23.15% <ø> (-25.88%) ⬇️
networking 24.78% <ø> (-51.43%) ⬇️
rpc 24.88% <ø> (-32.90%) ⬇️
consensus 0.92% <ø> (-60.15%) ⬇️
revm 1.32% <ø> (-27.21%) ⬇️
payload builder 8.16% <ø> (ø)
primitives 19.64% <ø> (-65.63%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ty

@mattsse mattsse added this pull request to the merge queue Oct 2, 2023
@mattsse mattsse added the C-test A change that impacts how or what we test label Oct 2, 2023
Merged via the queue into paradigmxyz:main with commit 3bd6079 Oct 2, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend custom rpc namespace example with tests
2 participants