Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade spammy log #4853

Merged
merged 1 commit into from
Sep 29, 2023
Merged

chore: downgrade spammy log #4853

merged 1 commit into from
Sep 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 29, 2023

this can be invoked when we manually download blocks and become a bit spammy, we also already log this here on FCU

warn!(target: "consensus::engine", ?error, ?state, "Failed to canonicalize the head hash");

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #4853 (3b7a049) into main (53ff254) will decrease coverage by 1.28%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/blockchain-tree/src/blockchain_tree.rs 83.61% <0.00%> (ø)

... and 62 files with indirect coverage changes

Flag Coverage Δ
integration-tests 12.94% <0.00%> (-2.69%) ⬇️
unit-tests 62.68% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 31.23% <ø> (-0.79%) ⬇️
blockchain tree 83.76% <0.00%> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 72.48% <ø> (-0.84%) ⬇️
trie 94.48% <ø> (ø)
txpool 48.41% <ø> (-1.10%) ⬇️
networking 73.71% <ø> (-3.03%) ⬇️
rpc 55.87% <ø> (-1.92%) ⬇️
consensus 61.06% <ø> (ø)
revm 28.54% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 84.09% <ø> (-1.20%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit bbe54eb Sep 29, 2023
23 checks passed
@mattsse mattsse deleted the matt/downgrade-spammy-log branch September 29, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants