Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default RPC limit #4838

Merged
merged 2 commits into from
Sep 28, 2023
Merged

default RPC limit #4838

merged 2 commits into from
Sep 28, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

should solve #4830

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #4838 (990c86e) into main (73db2d8) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
bin/reth/src/args/rpc_server_args.rs 56.03% <ø> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.11% <ø> (-0.01%) ⬇️
unit-tests 63.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.06% <ø> (-0.03%) ⬇️
blockchain tree 83.69% <ø> (ø)
pipeline 88.43% <ø> (-0.02%) ⬇️
storage (db) 73.23% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 49.53% <ø> (ø)
networking 76.43% <ø> (+0.02%) ⬆️
rpc 57.78% <ø> (-0.01%) ⬇️
consensus 62.59% <ø> (ø)
revm 28.48% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 86.19% <ø> (-0.03%) ⬇️

mattsse
mattsse approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@mattsse mattsse added this pull request to the merge queue Sep 28, 2023
@mattsse mattsse added M-changelog This change should be included in the changelog A-cli Related to the reth CLI labels Sep 28, 2023
@DoTheBestToGetTheBest
Copy link
Contributor Author

DoTheBestToGetTheBest commented Sep 28, 2023 •
edited
Loading

lgtm, ty

Thank you for giving this kind of opportunity to partcipate in the good issue. I'am more interested to take more issue and learn about reth more. Thank you lot.

Merged via the queue into paradigmxyz:main with commit 3ef0364 Sep 28, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DoTheBestToGetTheBest @mattsse