feat(tx-pool): Add new TransactionPool trait for getting the best transactions with blob fee #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 143 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PanGan21
commented
Sep 28, 2023
| @@ -245,6 +245,39 @@ impl<T: TransactionOrdering> TxPool<T> { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns an iterator that yields transactions that are ready to be included in the block with | |||
| /// the given base fee and optional blob fee. | |||
| pub(crate) fn best_transactions_with_attributes( | |||
There was a problem hiding this comment.
Hey @mattsse please let me know your opinion about this function and then I can also write the related unit tests
mattsse
requested changes
Sep 28, 2023
crates/transaction-pool/src/lib.rs
Outdated
Comment on lines
424
to
425
| base_fee: u64, | ||
| blob_fee: Option<u64>, |
There was a problem hiding this comment.
I want a new struct type for this, this way it's easier to call and it won't break if we need more attributes in the future
There was a problem hiding this comment.
I added BestTransactionsAttributes struct as the argument
| basefee: u64, | ||
| blob_fee: Option<u64>, | ||
| ) -> Vec<Arc<ValidPoolTransaction<T>>> { | ||
| unreachable!() |
There was a problem hiding this comment.
Suggested change
| unreachable!() | |
| Vec::new() |
mattsse
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4822