Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: minor fixes #4831

Merged
merged 3 commits into from
Sep 28, 2023
Merged

ci: minor fixes #4831

merged 3 commits into from
Sep 28, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 28, 2023

  • actions/checkout: depth -> fetch-depth
Unexpected input(s) 'depth', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'persist-credentials', 'path', 'clean', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
  • rust-cache: add with: cache-on-failure: true
  • Unpin most Ubuntu runners: as we know from Foundry, we only need to pin to Ubuntu-20.04 when building release binaries which users will consume, since otherwise they'll get libc errors.

@codecov

This comment was marked as off-topic.

@DaniPopes DaniPopes changed the title ci: fix checkout depth ci: minor fixes Sep 28, 2023
As we know [from Foundry](foundry-rs/foundry#5903), we only need to pin to Ubuntu-20.04
when building release binaries which users will consume, since
otherwise they'll get libc errors.
@DaniPopes DaniPopes added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 8e9937b Sep 28, 2023
23 checks passed
@DaniPopes DaniPopes deleted the dani/ci-depth branch September 28, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants