Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use u64 nonce field for prestate #4825

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: use u64 nonce field for prestate #4825

merged 1 commit into from
Sep 27, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 27, 2023 •
edited
Loading

@mattsse mattsse added A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #4825 (edf3a65) into main (0cdd302) will increase coverage by 0.00%.
The diff coverage is 80.59%.

Impacted file tree graph

Files Coverage Δ
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
...ates/rpc/rpc-types/src/eth/trace/geth/pre_state.rs 88.46% <84.37%> (-6.54%) ⬇️

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.13% <0.00%> (-0.02%) ⬇️
unit-tests 63.29% <80.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.09% <ø> (ø)
blockchain tree 83.69% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.21% <ø> (ø)
trie 94.52% <ø> (+0.03%) ⬆️
txpool 49.99% <ø> (-0.02%) ⬇️
networking 76.43% <ø> (ø)
rpc 57.85% <84.37%> (+0.12%) ⬆️
consensus 62.59% <ø> (ø)
revm 28.33% <0.00%> (ø)
payload builder 8.20% <ø> (ø)
primitives 86.34% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 29d66a1 Sep 27, 2023
23 checks passed
@mattsse mattsse deleted the matt/fix-prestate-nonce branch September 27, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @rkrasiuk @DaniPopes