Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blob subpool variants and state #4824

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 27, 2023

ref #4764

blob transactions should not mix with regular txs in queued and basefee pool and should be kept separately to not further complicate eviction handling

this adds a new state bit and Blob subpool variant, so that blob txs are either pending or blobpool.

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4824 (b1a9d38) into main (66fc196) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 45.23%.

Impacted file tree graph

Files Coverage Δ
crates/transaction-pool/src/pool/txpool.rs 73.53% <12.50%> (-0.32%) ⬇️
crates/transaction-pool/src/pool/state.rs 61.60% <52.94%> (+0.60%) ⬆️

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.17% <16.66%> (-0.01%) ⬇️
unit-tests 63.25% <45.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.11% <ø> (ø)
blockchain tree 83.69% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.15% <ø> (-0.20%) ⬇️
trie 94.48% <ø> (-0.04%) ⬇️
txpool 49.99% <45.23%> (+0.47%) ⬆️
networking 76.45% <ø> (-0.02%) ⬇️
rpc 57.72% <ø> (ø)
consensus 62.59% <ø> (ø)
revm 28.33% <ø> (ø)
payload builder 8.20% <ø> (ø)
primitives 86.36% <ø> (-0.02%) ⬇️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit ac6570f Sep 27, 2023
23 checks passed
@mattsse mattsse deleted the matt/add-blob-subpool-state branch September 27, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants