Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support trace_filter #4818

Merged
merged 5 commits into from
Oct 2, 2023
Merged

feat: support trace_filter #4818

merged 5 commits into from
Oct 2, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 27, 2023

Adds limited support for #4799

This currently enforces a block range and caps at 100 blocks (can be extended after some testing)

There is some room for perf improvements, like only tracing up until the highest relevant tx in a matching block. But let's check perf first.

FYI @tjayrush

@mattsse mattsse changed the title wip:feat: support trace_filter feat: support trace_filter Sep 30, 2023
@mattsse mattsse force-pushed the matt/add-trace-filter branch 2 times, most recently from b0fe3d7 to a68bb3b Compare September 30, 2023 10:39
@mattsse mattsse marked this pull request as ready for review September 30, 2023 10:39
@mattsse mattsse added C-enhancement New feature or request M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #4818 (c3e182f) into main (05198e9) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 45.94%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-api/src/trace.rs 100.00% <ø> (ø)
crates/rpc/rpc-types/src/eth/trace/filter.rs 63.63% <42.85%> (-36.37%) ⬇️
crates/rpc/rpc/src/trace.rs 41.23% <46.66%> (+1.14%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.54% <45.94%> (+0.02%) ⬆️
unit-tests 62.56% <1.35%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.28% <ø> (ø)
blockchain tree 80.44% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.34% <ø> (+0.02%) ⬆️
trie 94.48% <ø> (-0.04%) ⬇️
txpool 49.49% <ø> (-0.02%) ⬇️
networking 76.12% <ø> (-0.08%) ⬇️
rpc 57.73% <45.94%> (-0.07%) ⬇️
consensus 61.06% <ø> (ø)
revm 28.53% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.25% <ø> (-0.02%) ⬇️

@tjayrush
Copy link

Adds limited support for #4799

This currently enforces a block range and caps at 100 blocks (can be extended after some testing)

There is some room for perf improvements, like only tracing up until the highest relevant tx in a matching block. But let's check perf first.

FYI @tjayrush

This is great. I need to sync my node and then I'll start testing.

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like this is good enough for testing

@mattsse mattsse added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 74808ed Oct 2, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-trace-filter branch October 2, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants