Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump boa #4787

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore(deps): bump boa #4787

merged 2 commits into from
Sep 28, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 26, 2023

Closes #4761

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4787 (2e8acf4) into main (faf9a89) will decrease coverage by 0.20%.
Report is 27 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 61 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.11% <ø> (-0.40%) ⬇️
unit-tests 63.26% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.09% <ø> (-0.15%) ⬇️
blockchain tree 83.69% <ø> (ø)
pipeline 88.45% <ø> (-0.09%) ⬇️
storage (db) 73.23% <ø> (-0.26%) ⬇️
trie 94.45% <ø> (-0.04%) ⬇️
txpool 49.53% <ø> (+0.02%) ⬆️
networking 76.45% <ø> (-0.47%) ⬇️
rpc 57.79% <ø> (+0.09%) ⬆️
consensus 62.59% <ø> (-0.26%) ⬇️
revm 28.48% <ø> (+0.14%) ⬆️
payload builder 8.16% <ø> (-0.05%) ⬇️
primitives 86.21% <ø> (-0.31%) ⬇️

@rkrasiuk
Copy link
Member

some tests started failing w/ DataError { kind: MissingDataKey, .. }

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 26, 2023

... something broke in boa, I think

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.17.1 -> 0.17.3 fixed whatever was broken.

@DaniPopes DaniPopes added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit ec25f49 Sep 28, 2023
24 checks passed
@DaniPopes DaniPopes deleted the matt/bump-boa branch September 28, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove icu_ pinned deps
3 participants