Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add and fix more lints, improve docs #4765

Merged
merged 14 commits into from
Sep 25, 2023

fmt

b297ad8
Select commit
Loading
Failed to load commit list.
Merged

chore: add and fix more lints, improve docs #4765

fmt
b297ad8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 25, 2023 in 0s

68.02% (-0.14%) compared to 0f9def0

View this Pull Request on Codecov

68.02% (-0.14%) compared to 0f9def0

Details

Codecov Report

Merging #4765 (b297ad8) into main (0f9def0) will decrease coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 12.10%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli/ext.rs 6.79% <ø> (ø)
bin/reth/src/db/clear.rs 9.09% <ø> (ø)
bin/reth/src/db/get.rs 75.64% <ø> (ø)
bin/reth/src/dirs.rs 71.01% <0.00%> (ø)
bin/reth/src/node/cl_events.rs 0.00% <0.00%> (ø)
bin/reth/src/runner.rs 54.34% <0.00%> (-1.09%) ⬇️
crates/blockchain-tree/src/blockchain_tree.rs 83.61% <0.00%> (-0.11%) ⬇️
crates/consensus/auto-seal/src/lib.rs 0.00% <0.00%> (ø)
crates/consensus/beacon/src/engine/hooks/mod.rs 55.55% <0.00%> (-6.95%) ⬇️
crates/consensus/beacon/src/engine/hooks/prune.rs 77.92% <0.00%> (-7.80%) ⬇️
... and 85 more

... and 4 files with indirect coverage changes

Components Coverage Δ
reth binary 32.07% <22.22%> (-0.04%) ⬇️
blockchain tree 83.69% <50.00%> (-0.05%) ⬇️
pipeline 88.53% <ø> (ø)
storage (db) 73.49% <13.04%> (-0.22%) ⬇️
trie 94.52% <12.50%> (-0.25%) ⬇️
txpool 49.51% <40.00%> (-0.48%) ⬇️
networking 76.92% <4.65%> (-0.19%) ⬇️
rpc 57.67% <0.00%> (-0.03%) ⬇️
consensus 62.84% <5.88%> (-0.26%) ⬇️
revm 28.33% <100.00%> (ø)
payload builder 8.20% <0.00%> (-0.12%) ⬇️
primitives 86.50% <42.85%> (-0.06%) ⬇️