Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block overrides inconsistencies #4746

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 23, 2023

ref #4731

fixes some inconsistencies in blockoverrides struct

geth uses number, erigon uses blockNumber: adds missing alias

also adds additional blockHash argument for overriding past blockhashes

@mattsse mattsse added M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #4746 (ebea5bf) into main (344ffbd) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 30.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/revm_utils.rs 37.14% <6.66%> (-1.32%) ⬇️
crates/rpc/rpc-types/src/eth/block.rs 59.06% <100.00%> (+1.62%) ⬆️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.51% <5.00%> (-0.02%) ⬇️
unit-tests 63.47% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.11% <ø> (ø)
blockchain tree 83.73% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.70% <ø> (ø)
trie 94.77% <ø> (+0.03%) ⬆️
txpool 49.50% <ø> (-0.33%) ⬇️
networking 77.10% <ø> (-0.01%) ⬇️
rpc 57.52% <30.00%> (-0.04%) ⬇️
consensus 63.09% <ø> (ø)
revm 28.33% <ø> (ø)
payload builder 8.32% <ø> (ø)
primitives 86.52% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 24, 2023
Merged via the queue into main with commit 7a0781c Sep 24, 2023
22 checks passed
@mattsse mattsse deleted the matt/block-overrides-inconsist branch September 24, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants