Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable EIP-7516 hive tests #4717

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat: enable EIP-7516 hive tests #4717

merged 1 commit into from
Sep 21, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 21, 2023

EIP-7516 pyspec hive tests are added here: https://github.com/ethereum/execution-spec-tests/releases/tag/v1.0.4

This enables these new tests. They are all prefixed by eip7516_blobgasfee, so the limit param here should cover all of them.

@Rjected Rjected added C-enhancement New feature or request C-test A change that impacts how or what we test M-eip This change relates to the implementation of an EIP E-cancun Related to the Cancun network upgrade labels Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #4717 (d6f8414) into main (acd7470) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <ø> (-0.01%) ⬇️
unit-tests 63.37% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.73% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.52% <ø> (ø)
trie 94.73% <ø> (-0.04%) ⬇️
txpool 50.28% <ø> (+0.46%) ⬆️
networking 77.25% <ø> (+0.10%) ⬆️
rpc 57.86% <ø> (-0.01%) ⬇️
consensus 63.09% <ø> (ø)
revm 28.38% <ø> (ø)
payload builder 8.35% <ø> (ø)
primitives 86.53% <ø> (-0.02%) ⬇️

@gakonst gakonst added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit bb0da4a Sep 21, 2023
22 checks passed
@gakonst gakonst deleted the dan/enable-eip-7516-hive branch September 21, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade M-eip This change relates to the implementation of an EIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants