fix: make into_transaction fallible #4710
Conversation
Codecov Report
... and 50 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| /// Converts a typed transaction request into a primitive transaction. | ||
| /// | ||
| /// Returns `None` if any of the following are true: | ||
| /// - `nonce` is greater than [`u64::MAX`] |
There was a problem hiding this comment.
just checked geth reference and nonce on rpc methods is U64,
I think we can also change this in our types?
There was a problem hiding this comment.
There was a problem hiding this comment.
Is there a reason we're using ruint for these txrequest anyway? I don't see any serde derives or whatever
There was a problem hiding this comment.
there are two steps here
TransactionRequest -> TypedTransactionRequest -> Transaction
arguably this could also be one step, but having a typed request is still useful
Fixes #4704