Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine, snapshot): snapshot hook #4690

Merged
merged 16 commits into from
Sep 28, 2023
Merged

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 20, 2023

Ref #4588

This PR adds (but doesn't enable yet) an engine hook for snapshotting and introduces a snapshot crate for everything related to creation of snapshots, i.e. the Snapshotter routine that will be triggered by SnapshotHook from the engine.

@shekhirin shekhirin added A-static-files Related to static files C-enhancement New feature or request labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4690 (54b0ee9) into main (c6ef9d7) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 66.54%.

Impacted file tree graph

Files Coverage Δ
...es/consensus/beacon/src/engine/hooks/controller.rs 79.41% <100.00%> (ø)
crates/consensus/beacon/src/engine/hooks/mod.rs 55.55% <ø> (ø)
crates/consensus/beacon/src/engine/mod.rs 73.14% <100.00%> (-0.07%) ⬇️
crates/snapshot/src/error.rs 0.00% <0.00%> (ø)
crates/consensus/beacon/src/engine/hooks/prune.rs 75.00% <27.27%> (-2.93%) ⬇️
crates/snapshot/src/snapshotter.rs 94.68% <94.68%> (ø)
...ates/consensus/beacon/src/engine/hooks/snapshot.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.55% <0.00%> (-0.06%) ⬇️
unit-tests 62.73% <66.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.06% <ø> (ø)
blockchain tree 83.76% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.31% <ø> (+0.02%) ⬆️
trie 94.48% <ø> (ø)
txpool 49.54% <ø> (ø)
networking 76.46% <ø> (+0.01%) ⬆️
rpc 57.79% <ø> (ø)
consensus 61.41% <11.57%> (-1.24%) ⬇️
revm 28.54% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.28% <ø> (+0.01%) ⬆️

@shekhirin shekhirin marked this pull request as ready for review September 20, 2023 19:46
@joshieDo joshieDo mentioned this pull request Sep 21, 2023
@shekhirin shekhirin force-pushed the alexey/engine-hook-snapshot branch 2 times, most recently from a3b7df6 to d7cdaaf Compare September 21, 2023 12:33
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nits

crates/consensus/beacon/src/engine/hooks/snapshot.rs Outdated Show resolved Hide resolved
crates/snapshot/src/lib.rs Show resolved Hide resolved
@shekhirin shekhirin added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@shekhirin shekhirin added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 760a515 Sep 28, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/engine-hook-snapshot branch September 28, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants