Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify get precompiles #4681

Merged
merged 3 commits into from
Sep 20, 2023
Merged

chore: simplify get precompiles #4681

merged 3 commits into from
Sep 20, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 20, 2023

ref bluealloy/revm#733

use existing conversion function and get rid of redundant vec allocation

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #4681 (874cf29) into main (a52b433) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/revm/revm-inspectors/src/access_list.rs 50.00% <100.00%> (ø)
crates/rpc/rpc/src/eth/api/call.rs 45.93% <100.00%> (ø)
crates/rpc/rpc/src/eth/revm_utils.rs 38.46% <100.00%> (+0.49%) ⬆️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <100.00%> (-0.02%) ⬇️
unit-tests 63.31% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.51% <ø> (ø)
trie 94.77% <ø> (+0.03%) ⬆️
txpool 49.44% <ø> (ø)
networking 77.12% <ø> (+0.01%) ⬆️
rpc 57.84% <100.00%> (+0.02%) ⬆️
consensus 63.21% <ø> (ø)
revm 28.24% <100.00%> (ø)
payload builder 8.45% <ø> (ø)
primitives 86.53% <ø> (-0.03%) ⬇️

Rjected
Rjected approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Sep 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 20, 2023
@Rjected Rjected added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit a29f102 Sep 20, 2023
22 checks passed
@Rjected Rjected deleted the matt/simplify-get-precompiles branch September 20, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected