Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(state): change after selfdestruct #4378

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Port of #4198 to the new state API.

@rkrasiuk rkrasiuk added A-execution Related to the Execution and EVM C-test A change that impacts how or what we test labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4378 (87fd240) into rakita/revm_state (759eaf5) will decrease coverage by 18.00%.
Report is 86 commits behind head on rakita/revm_state.
The diff coverage is 34.98%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/pruning_args.rs 20.00% <0.00%> (+10.00%) ⬆️
bin/reth/src/args/rpc_server_args.rs 27.58% <0.00%> (-26.26%) ⬇️
bin/reth/src/chain/import.rs 6.89% <0.00%> (-0.06%) ⬇️
bin/reth/src/db/list.rs 1.47% <0.00%> (-1.10%) ⬇️
bin/reth/src/db/mod.rs 2.40% <0.00%> (-4.88%) ⬇️
bin/reth/src/db/tui.rs 0.00% <0.00%> (ø)
bin/reth/src/debug_cmd/execution.rs 1.12% <0.00%> (-0.03%) ⬇️
bin/reth/src/debug_cmd/in_memory_merkle.rs 1.27% <0.00%> (-0.03%) ⬇️
bin/reth/src/debug_cmd/merkle.rs 0.80% <0.00%> (-0.34%) ⬇️
bin/reth/src/debug_cmd/mod.rs 0.00% <0.00%> (ø)
... and 138 more

... and 158 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.10% <5.49%> (+0.61%) ⬆️
unit-tests 45.21% <34.03%> (-18.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 20.51% <36.26%> (-4.86%) ⬇️
blockchain tree 42.13% <12.50%> (-40.92%) ⬇️
pipeline 63.05% <61.90%> (-27.02%) ⬇️
storage (db) 50.66% <46.50%> (-23.93%) ⬇️
trie 61.16% <ø> (-33.55%) ⬇️
txpool 39.98% <16.12%> (-8.21%) ⬇️
networking 60.99% <16.70%> (-16.47%) ⬇️
rpc 44.62% <6.27%> (-12.86%) ⬇️
consensus 50.70% <30.92%> (-13.06%) ⬇️
revm 18.32% <50.33%> (-13.95%) ⬇️
payload builder 6.90% <0.00%> (+0.33%) ⬆️
primitives 65.97% <48.25%> (-21.82%) ⬇️

Copy link
Collaborator

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit c42eec2 into rakita/revm_state Aug 28, 2023
12 of 19 checks passed
@rakita rakita deleted the rkrasiuk/test-change-after-selfdestruct branch August 28, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants