feat: add eip4844 tx type id #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/add-blob-tx-type-id
branch
from
a291875
to
15b7cdd
Compare
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rjected
approved these changes
Jul 26, 2023
| @@ -268,7 +267,9 @@ pub struct TxEip4844 { | |||
| pub blob_hashes: Vec<H256>, | |||
|
|
|||
| /// Max fee per data gas | |||
| pub max_fee_per_blob: u128, | |||
| /// | |||
| /// aka BlobFeeCap | |||
There was a problem hiding this comment.
why not maintain blob instead of data? (which is in accordance to the eip)
There was a problem hiding this comment.
very good point, renamed so it matches eip
onbjerg
added
C-enhancement
onbjerg
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2893