Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): remove invalid block hash variant #2954

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 2, 2023

Closes #2947

this variant is deprecated with v2 and can also be removed from V1

ethereum/go-ethereum#26696

geth also no longer has it

https://github.com/ethereum/go-ethereum/blob/73697529994e14996b7740730481e926d5ec3e40/beacon/engine/errors.go#L61-L61

@mattsse mattsse requested review from rkrasiuk and Rjected as code owners June 2, 2023 09:57
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Jun 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #2954 (78983f4) into main (43f421d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
+ Coverage   71.05%   71.10%   +0.04%     
==========================================
  Files         517      517              
  Lines       67056    67049       -7     
==========================================
+ Hits        47646    47672      +26     
+ Misses      19410    19377      -33     
Flag Coverage Δ
integration-tests 17.30% <0.00%> (+<0.01%) ⬆️
unit-tests 66.00% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/consensus/beacon/src/engine/forkchoice.rs 79.06% <ø> (+1.79%) ⬆️
crates/rpc/rpc-types/src/eth/engine/payload.rs 87.30% <100.00%> (+2.82%) ⬆️

... and 14 files with indirect coverage changes

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added this pull request to the merge queue Jun 2, 2023
Merged via the queue into main with commit a03c380 Jun 2, 2023
@onbjerg onbjerg deleted the matt/rm-invalid-block-hash-variant branch June 2, 2023 13:00
gakonst added a commit to TechieBoy/reth that referenced this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INVALID_BLOCK_HASH is depracted with engineV2
4 participants