Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use caching layer when fetching blocks for logs #2350

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

chirag-bgh
Copy link
Contributor

Closes #2302

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #2350 (af32464) into main (370c395) will decrease coverage by 10.37%.
The diff coverage is 42.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #2350       +/-   ##
===========================================
- Coverage   70.77%   60.40%   -10.37%     
===========================================
  Files         480      480               
  Lines       58129    58130        +1     
===========================================
- Hits        41142    35115     -6027     
- Misses      16987    23015     +6028     
Flag Coverage Δ
integration-tests 18.83% <42.85%> (+2.37%) ⬆️
unit-tests 54.40% <0.00%> (-12.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-builder/src/auth.rs 46.95% <0.00%> (ø)
crates/rpc/rpc/src/eth/filter.rs 7.51% <50.00%> (+0.53%) ⬆️
crates/rpc/rpc-builder/src/lib.rs 60.20% <100.00%> (+1.76%) ⬆️

... and 183 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Apr 23, 2023
@mattsse mattsse merged commit 1026be0 into paradigmxyz:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use caching layer when fetching blocks for logs
3 participants