-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trace_replayBlockTransactions #2141
Conversation
crates/rpc/rpc/src/trace.rs
Outdated
pub async fn replay_block_transactions( | ||
&self, | ||
block_id: BlockId, | ||
trace_types: HashSet<TraceType>, | ||
) -> Result<Option<Vec<TraceResultsWithTransactionHash>>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is basically the same thing as trace_block
, but the recorded traces differ:
https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc/src/trace.rs#L238-L241
what we should do here is:
Convert trace_block
into a helper function that can also unify replay_block_transactions
. This new function should accept a TracingInspectorConfig
and a callback function Fn()
like this:
https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc/src/eth/api/transactions.rs#L136-L140
so both trace block functions call this new helper functions but with a different config and callback (that converts the inspector into traces)
does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
Yes this make sense
hey @chirag-bgh |
Bump @chirag-bgh - we're sprinting towards release so would love to merge this asap. If you cannot prioritize it's all good! We can take it over, thank you for getting the ball rolling.. |
I'm very sorry for keeping this stale. You can take it over! |
1de5fcb
to
5ca2b3c
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2141 +/- ##
==========================================
+ Coverage 71.93% 71.96% +0.02%
==========================================
Files 462 462
Lines 55617 55654 +37
==========================================
+ Hits 40008 40049 +41
+ Misses 15609 15605 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Closes #2010
Implements
trace_replayBlockTransactions