Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pooled_transaction_max #1971

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

chirag-bgh
Copy link
Contributor

Closes #1950

@codecov-commenter
Copy link

Codecov Report

Merging #1971 (d9fe7d0) into main (21e34da) will decrease coverage by 25.34%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1971       +/-   ##
===========================================
- Coverage   73.17%   47.83%   -25.34%     
===========================================
  Files         425      425               
  Lines       52045    52079       +34     
===========================================
- Hits        38082    24911    -13171     
- Misses      13963    27168    +13205     
Flag Coverage Δ
integration-tests 17.38% <0.00%> (-2.10%) ⬇️
unit-tests 42.26% <0.00%> (-25.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/network/src/transactions.rs 18.64% <0.00%> (+0.05%) ⬆️
crates/transaction-pool/src/lib.rs 29.83% <0.00%> (-4.95%) ⬇️
crates/transaction-pool/src/traits.rs 2.97% <ø> (ø)

... and 189 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm

@mattsse mattsse merged commit ea4b4f7 into paradigmxyz:main Mar 24, 2023
@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Mar 24, 2023
@chirag-bgh chirag-bgh deleted the pooled_tx_max branch March 24, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add TransactionPool::pooled_transaction_max
3 participants