Skip to content

chore: fix typos terminology in StorageShardedKey comments and variables #17778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix typos terminology in StorageShardedKey comments and variables #17778

wants to merge 1 commit into from

Conversation

davidjsonn
Copy link
Contributor

Fix inconsistent terminology in StorageShardedKey:

  • Change transition to block in documentation examples to match
    the base ShardedKey pattern and align with blockchain terminology
  • Update field comment from transition id to block number to match
    the actual field name highest_block_number
  • Rename variables in decode() from tx_num_index/highest_tx_number to
    block_num_index/highest_block_number for consistency

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Reth Tracker
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidjsonn