Split blob helpers into BlobPoolExt (fixes #294) #17623
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher <chrisgroenev@gmail.com>
chainguru1014
requested review from
mattsse,
Rjected,
RomanHodulak,
fgimenez,
onbjerg,
klkvr and
gakonst
as code owners
github-actions
bot
added
the
S-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
L2s like RISE and OP do not need EIP-4844 blob transaction helpers. Currently, the core
TransactionPooltrait requires every consumer to implement these blob-related methods, even when they are unused. That forces downstream crates to depend onalloy-eipsandblobstore, increasing compile time and dependency size.This change splits those methods into a new trait
BlobPoolExtbehind the optional"blob"feature. This allows downstream projects to disable the feature cleanly viadefault-features = false.What changed
BlobPoolExt, gated behind#[cfg(feature = "blob")]get_blob,delete_blobs, etc.) out ofTransactionPoolBlobPoolExtforPool<V, T, S>andNoopTransactionPool--no-default-features