Skip to content

perf: perform contains check without alloc #16136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

perf: perform contains check without alloc #16136

merged 1 commit into from
May 9, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented May 9, 2025

smol #15312 followup

this check is equivalent and doesn't require multiple lookups and potential allocs

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker May 9, 2025
@mattsse mattsse added the C-perf A change motivated by improving speed, memory usage or disk footprint label May 9, 2025
@mattsse mattsse enabled auto-merge May 9, 2025 12:36
Rjected
Rjected approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep makes sense

@mattsse mattsse added this pull request to the merge queue May 9, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker May 9, 2025
Merged via the queue into main with commit 2033980 May 9, 2025
46 checks passed
@mattsse mattsse deleted the matt/perform-auth-check-without-alloc branch May 9, 2025 20:55
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected