test: handle commit event properly by pool maintaining #16125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 8, 2025
crates/transaction-pool/Cargo.toml
Outdated
Comment on lines
67
to
72
| reth-ethereum = { workspace = true, features = [ | ||
| "test-utils", | ||
| "network", | ||
| "pool", | ||
| "provider", | ||
| ] } |
There was a problem hiding this comment.
this we can't really do because this is a cyclic dep graph, that only works because this is a dev-dep, so we should flatten these.
or move this test into reth-ethereum-node entreily
Comment on lines
89
to
92
| node.inner.provider.clone(), | ||
| txpool.clone(), | ||
| node.inner.provider.clone().canonical_state_stream(), | ||
| executor.clone(), |
There was a problem hiding this comment.
hmm, for this test, we likely just need a way to mock the subscription?
sow e can ditch the entire node setup?
|
@mattsse updated! |
mattsse
requested changes
May 9, 2025
crates/ethereum/node/Cargo.toml
Outdated
| @@ -56,6 +56,7 @@ reth-payload-primitives.workspace = true | |||
| reth-e2e-test-utils.workspace = true | |||
| reth-rpc-eth-api.workspace = true | |||
| reth-tasks.workspace = true | |||
| reth-ethereum = { workspace = true, features = ["pool"] } | |||
There was a problem hiding this comment.
we can't import this here either, because this is now cyclic,
we need to import the crates we need, which is the pool crate
mattsse
approved these changes
May 9, 2025
mattsse
added
A-tx-pool
|
fyi @Rimeeeeee once this is merged we can also reuse the OkValidator for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.