chore(op-sdk): Add ZST aggregate ty for OP NodeTypes
#16104
+147
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
emhane
added
C-debt
…nto emhane/op-types-crate
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #16105
Towards #15743
Adds a simple OP
NodeTypestypeOpTypesin a new cratereth-optimism-node-types, which can be imported intoreth-optimism-rpc, etc. without creating cyclical deps withreth-optimism-nodecrate.Using
AnyNodeTypesis unnecessarily complex as long as each AT onNodeTypesisn't implemented for()or a noop type. Since theNodeTypesaggregate type is stateless, it is ok to use all the optimismOpTypesin types which will only have to use a subset of thoseNodeTypes, as it means no stateful components have to be cumbersomely and counterintuitively constructed just to satisfy the type (like when usingOpNodejust to access itsNodeTypesimpl 👎).