refactor: move ExtendedTxEnvelope to reth-primitives-traits #16102
Conversation
iTranscend
requested review from
Rjected,
joshieDo,
mattsse,
klkvr and
gakonst
as code owners
| /// A [`SignedTransaction`] implementation that combines the [`OpTxEnvelope`] and another | ||
| /// transaction type. | ||
| pub type ExtendedOpTxEnvelope<T> = ExtendedTxEnvelope<OpTxEnvelope, T>; |
| use revm_primitives::{Address, Bytes, TxKind, B256, U256}; | ||
|
|
||
| use crate::{ | ||
| serde_bincode_compat::SerdeBincodeCompat, |
There was a problem hiding this comment.
this impl we need to feature gate, with
reth/crates/primitives-traits/Cargo.toml
Line 119 in 22452e8
| @@ -9,12 +9,14 @@ use alloy_primitives::{bytes::Buf, ChainId, TxHash}; | |||
| use alloy_rlp::{BufMut, Decodable, Encodable, Result as RlpResult}; | |||
| use op_alloy_consensus::OpTxEnvelope; | |||
| use reth_codecs::Compact; | |||
There was a problem hiding this comment.
we also need to feature gate this impl with reth-codecs
| @@ -33,10 +35,14 @@ macro_rules! delegate { | |||
| /// types must be unique. | |||
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize, Hash, Eq, PartialEq)] | |||
There was a problem hiding this comment.
we also need to feature gate serde, see other types in this crate for reference
mattsse
added
C-enhancement
fgimenez
force-pushed
the
feat/move-ext-tx-envelope
branch
from
a718c7e to
fd97853
Compare
| impl<Tx> TryFrom<ExtendedTxEnvelope<OpTxEnvelope, Tx>> | ||
| for ExtendedTxEnvelope<OpPooledTransaction, Tx> |
There was a problem hiding this comment.
we either need to relax this so that this works for any Builtin type or feature gat behind op feature
| } | ||
| } | ||
| } | ||
|
|
||
| impl From<OpPooledTransaction> for ExtendedTxEnvelope<OpTxEnvelope, CustomTransactionEnvelope> { | ||
| impl<Tx> From<OpPooledTransaction> for ExtendedTxEnvelope<OpTxEnvelope, Tx> { |
There was a problem hiding this comment.
this also needs an op feature
| { | ||
| fn to_compact<Buf>(&self, buf: &mut Buf) -> usize | ||
| #[cfg(feature = "reth-codec")] | ||
| mod compact { |
There was a problem hiding this comment.
I'd like to avoid this compact module and use full paths instead, this is how we do compact feature gate elsewhere
This PR moves
ExtendedTxEnvelopeand its impls to thereth-primitives-traitscrateresolves #16091