feat: use custom tx in custom-node #16054
Merged
+337
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soubhik-10
requested review from
Rjected,
joshieDo,
mattsse,
klkvr and
gakonst
as code owners
mattsse
requested changes
May 6, 2025
There was a problem hiding this comment.
this is great progress, what is still missing is custom
.pool(OpPoolBuilder::default())
.consensus(OpConsensusBuilder::default())
https://github.com/paradigmxyz/reth/blob/main/examples/custom-node/src/lib.rs#L57-L58
what we need here is similar to the Op related builder types that are currently used here but adapted for the custom types.
we can likely make this work if we can reuse:
https://github.com/paradigmxyz/reth/blob/main/crates/optimism/txpool/src/transaction.rs#L29-L32
and implement the mising traits for the extended pooled type
so I think next step here would be ensure that we can ad our CustomPoolBuilder and CustomConsensusBuilder
mattsse
approved these changes
May 8, 2025
mattsse
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task 2 and eventually closes #16018