Skip to content

Rename metrics for getBlobsV2 #16031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Rename metrics for getBlobsV2 #16031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/rpc/rpc-engine-api/src/engine_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,10 +938,17 @@ where

if let Ok(blobs) = &res {
let blobs_found = blobs.iter().flatten().count();
let blobs_missed = hashes_len - blobs_found;

self.inner.metrics.blob_metrics.blob_count.increment(blobs_found as u64);
self.inner.metrics.blob_metrics.blob_misses.increment(blobs_missed as u64);
self.inner.metrics.blob_metrics.get_blobs_requests_blobs_total.increment(hashes_len as u64);
self.inner.metrics.blob_metrics.get_blobs_requests_blobs_in_blobpool_total.increment(blobs_found as u64);

if blobs_found == hashes_len {
self.inner.metrics.blob_metrics.get_blobs_requests_success_total.increment(1);
} else {
self.inner.metrics.blob_metrics.get_blobs_requests_failure_total.increment(1);
}
} else {
self.inner.metrics.blob_metrics.get_blobs_requests_failure_total.increment(1);
}

res
Expand Down
9 changes: 9 additions & 0 deletions crates/rpc/rpc-engine-api/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,15 @@ pub(crate) struct BlobMetrics {
pub(crate) blob_count: Counter,
/// Count of blob misses
pub(crate) blob_misses: Counter,

/// Number of blobs requested via getBlobsV2
pub(crate) get_blobs_requests_blobs_total: Counter,
/// Number of blobs requested via getBlobsV2 that are present in the blobpool
pub(crate) get_blobs_requests_blobs_in_blobpool_total : Counter,
/// Number of times getBlobsV2 responded with “hit”
pub(crate) get_blobs_requests_success_total: Counter,
/// Number of times getBlobsV2 responded with “miss”
pub(crate) get_blobs_requests_failure_total : Counter,
}

impl NewPayloadStatusResponseMetrics {
Expand Down
Loading