feat: add precompile cache for execution #15928

fgimenez · 2025-04-25T12:44:37Z

Closes #13984

codspeed-hq · 2025-04-25T15:39:54Z

CodSpeed Performance Report

Merging #15928 will not alter performance

_{Comparing fgimenez/precompile-cache-hotswap (948c04a) with main (a3c067c)}

Summary

✅ 77 untouched benchmarks

kevaundray · 2025-04-25T16:02:43Z

ref: #13984

mattsse · 2025-04-30T18:04:06Z

crates/engine/tree/src/tree/precompile_cache.rs

+        |data: &Bytes, gas_limit: u64| -> PrecompileResult {
+            Self::new(precompile, cache).call(data, gas_limit)
+        }
+        .into()


can we add a helper constructor to DynPrecompile that accepts a closure, this is easier than doing from conversions which suck a bit for closures

rn there's no way to construct DynPrecompile from just a impl Precompile, so we'd need a helper for it in alloy-evm first

mattsse · 2025-04-30T18:05:59Z

crates/engine/tree/src/tree/precompile_cache.rs

+        |data: &Bytes, gas_limit: u64| -> PrecompileResult {
+            Self::new(precompile, cache).call(data, gas_limit)
+        }


this isn't quite right, because this is the precompile fn, which internally now creates a new CachedPrecompile and invokes it

the conversion we need here Self::new(precompile, cache).into()

mattsse · 2025-04-30T18:07:21Z

crates/optimism/rpc/src/eth/call.rs

+            authorization_list: authorization_list
+                .unwrap_or_default()
+                .into_iter()
+                .map(Either::Left)
+                .collect(),


hmm, this is a bit horrible,

I don't think it's useful to do this for auths individually, but this is a revm api discussion

klkvr · 2025-04-30T19:46:54Z

crates/engine/tree/src/tree/mod.rs

+        if self.config.precompile_cache_enabled() {
+            let mut evm = self
+                .evm_config
+                .evm_for_block(StateProviderDatabase::new(&state_provider), block.header());
+            let precompiles = evm.precompiles_mut();
+            precompiles.map_precompiles(|_, precompile| {
+                CachedPrecompile::wrap(precompile, self.precompile_cache.clone())
+            })
+        }


this does not yet have effect right? because this evm does not belong to the executor we're instantiating below

yes exactly, we should obtain the evm from the executor, with the current local block executor provider trait we could extend it to get an evm config

crates/engine/tree/src/tree/precompile_cache.rs

mattsse · 2025-05-08T14:52:43Z

crates/engine/tree/src/tree/precompile_cache.rs

+
+impl Precompile for CachedPrecompile {
+    fn call(&self, data: &[u8], gas_limit: u64) -> PrecompileResult {
+        let key = CacheKey(Bytes::copy_from_slice(data));


we can solve this more efficiently because we only need Borrow here, but we can take care of this seperately.

mattsse · 2025-05-08T14:53:15Z

crates/engine/tree/src/tree/precompile_cache.rs

+}
+
+impl Precompile for CachedPrecompile {
+    fn call(&self, data: &[u8], gas_limit: u64) -> PrecompileResult {


this is a lot simpler now compared to what we previously had :D

mattsse · 2025-05-08T14:54:35Z

crates/rpc/rpc-eth-types/src/error/mod.rs

@@ -581,6 +581,7 @@ impl From<InvalidTransaction> for RpcInvalidTransactionError {
            InvalidTransaction::Eip1559NotSupported |
            InvalidTransaction::Eip4844NotSupported |
            InvalidTransaction::Eip7702NotSupported => Self::TxTypeNotSupported,
+            _ => todo!(),


we cant have a todo here

this must be exhaustive and must not panic

mattsse · 2025-05-08T14:56:10Z

examples/custom-evm/src/main.rs

+        if spec == SpecId::PRAGUE {
+            evm = evm.with_precompiles(PrecompilesMap::from_static(prague_custom()));


this check I dont understand

why do we need this?

it comes from the current example, the custom precompiles come from Prague's https://github.com/paradigmxyz/reth/blob/main/examples/custom-evm/src/main.rs#L110-L124

fgimenez requested a review from gakonst as a code owner April 25, 2025 12:44

github-project-automation bot added this to Reth Tracker Apr 25, 2025

github-project-automation bot moved this to Backlog in Reth Tracker Apr 25, 2025

fgimenez marked this pull request as draft April 25, 2025 12:44

jenpaff assigned fgimenez Apr 29, 2025

jenpaff moved this from Backlog to In Progress in Reth Tracker Apr 29, 2025

jenpaff linked an issue Apr 29, 2025 that may be closed by this pull request

Precompile Caching #13984

Closed

jenpaff removed this from Reth Tracker Apr 29, 2025

github-project-automation bot added this to Reth Tracker Apr 29, 2025

github-project-automation bot moved this to Backlog in Reth Tracker Apr 29, 2025

fgimenez added the C-perf A change motivated by improving speed, memory usage or disk footprint label Apr 29, 2025

fgimenez moved this from Backlog to In Progress in Reth Tracker Apr 29, 2025

fgimenez force-pushed the fgimenez/precompile-cache-hotswap branch 2 times, most recently from 82a7a16 to d0b358a Compare April 30, 2025 14:27

fgimenez changed the base branch from main to fgimenez/remove-block-executor-provider April 30, 2025 14:28

fgimenez force-pushed the fgimenez/remove-block-executor-provider branch from 4946af7 to 324a283 Compare April 30, 2025 17:54

fgimenez force-pushed the fgimenez/precompile-cache-hotswap branch from 90b76d8 to dda55da Compare April 30, 2025 17:55

mattsse requested changes Apr 30, 2025

View reviewed changes

klkvr reviewed Apr 30, 2025

View reviewed changes

klkvr changed the base branch from fgimenez/remove-block-executor-provider to main May 2, 2025 16:56

klkvr force-pushed the fgimenez/precompile-cache-hotswap branch from d5fe418 to 4b85afa Compare May 2, 2025 16:56

fgimenez force-pushed the fgimenez/precompile-cache-hotswap branch 5 times, most recently from fc8b054 to dbee913 Compare May 6, 2025 14:46

fgimenez marked this pull request as ready for review May 6, 2025 14:48

fgimenez requested a review from Rjected as a code owner May 6, 2025 14:48

fgimenez force-pushed the fgimenez/precompile-cache-hotswap branch from ad37727 to 2beaf94 Compare May 7, 2025 10:01

shekhirin reviewed May 7, 2025

View reviewed changes

crates/engine/tree/src/tree/precompile_cache.rs Show resolved Hide resolved

crates/engine/tree/src/tree/precompile_cache.rs Outdated Show resolved Hide resolved

crates/engine/tree/src/tree/precompile_cache.rs Outdated Show resolved Hide resolved

fgimenez added 4 commits May 7, 2025 16:15

do not cache errors

1d5fe7d

use counters instead of gauges

efc0ee1

set cache size and cache entry tuple struct

ed0603d

CacheEntry methods

c1590e4

fgimenez mentioned this pull request May 7, 2025

Create custom weigher for PrecompileCache #16112

Open

fgimenez and others added 7 commits May 7, 2025 17:24

only increment cache miss on call success

235e6c4

bump deps

66cb117

bump deps

71068af

bump revm

326880b

Merge branch 'main' into fgimenez/precompile-cache-hotswap

6ec32ca

Cargo.lock

4999fa2

bump

3cee303

mattsse approved these changes May 8, 2025

View reviewed changes

fgimenez added 2 commits May 8, 2025 15:39

allow MPL-2.0 license

4b313df

match pending errors

e3da935

klkvr approved these changes May 8, 2025

View reviewed changes

klkvr added this pull request to the merge queue May 8, 2025

mattsse removed this pull request from the merge queue due to a manual request May 8, 2025

fix: upgrade legacy

948c04a

mattsse added this pull request to the merge queue May 9, 2025

Merged via the queue into main with commit 2054a37 May 9, 2025
74 of 78 checks passed

mattsse deleted the fgimenez/precompile-cache-hotswap branch May 9, 2025 10:04

github-project-automation bot moved this from In Progress to Done in Reth Tracker May 9, 2025

nora-coder-dot mentioned this pull request May 9, 2025

refactor: use moka sync cache for the compiler cache instead of Arc<RwLock<LruCache<K, V>>> MetisProtocol/metis-sdk#196

Merged

mattsse restored the fgimenez/precompile-cache-hotswap branch May 9, 2025 13:08

nora-coder-dot mentioned this pull request May 10, 2025

[WIP] Global State Cache Integration MetisProtocol/reth#1

Closed

3 tasks

jenpaff moved this from Done to Completed in Reth Tracker May 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add precompile cache for execution #15928

feat: add precompile cache for execution #15928

fgimenez commented Apr 25, 2025 •

edited by klkvr

Loading

codspeed-hq bot commented Apr 25, 2025 •

edited

Loading

kevaundray commented Apr 25, 2025

mattsse Apr 30, 2025

klkvr May 2, 2025

mattsse Apr 30, 2025

mattsse Apr 30, 2025

klkvr Apr 30, 2025

fgimenez Apr 30, 2025

mattsse May 8, 2025

mattsse May 8, 2025

mattsse May 8, 2025

fgimenez May 8, 2025

mattsse May 8, 2025

fgimenez May 8, 2025

		if spec == SpecId::PRAGUE {
		evm = evm.with_precompiles(PrecompilesMap::from_static(prague_custom()));

feat: add precompile cache for execution #15928

feat: add precompile cache for execution #15928

Conversation

fgimenez commented Apr 25, 2025 • edited by klkvr Loading

codspeed-hq bot commented Apr 25, 2025 • edited Loading

Merging #15928 will not alter performance

Summary

kevaundray commented Apr 25, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fgimenez commented Apr 25, 2025 •

edited by klkvr

Loading

codspeed-hq bot commented Apr 25, 2025 •

edited

Loading