feat: Make DatabaseStateRoot stateful #15760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iTranscend
requested review from
rkrasiuk,
Rjected and
shekhirin
as code owners
iTranscend
requested review from
rakita,
joshieDo,
onbjerg and
mattsse
as code owners
iTranscend
changed the title
Rjected
requested changes
Apr 22, 2025
Comment on lines
+22
to
+26
| /// Trait for creating a new [`StateRoot`] instance from a database transaction. | ||
| pub trait StateRootFromTx<'a, TX> { | ||
| /// Create a new [`StateRoot`] instance. | ||
| fn from_tx(tx: &'a TX) -> Self; | ||
| } |
There was a problem hiding this comment.
Do we need a trait for this? I am not sure that we do, we should just be able to implement from_tx on the things that implement DatabaseStateRoot
There was a problem hiding this comment.
Adding from_tx to the things that implement DatabaseStateRoot (in this case StateRoot) introduces a cyclic dependency between the reth-trie and the reth-trie-db crates.
If we want from_tx implemented on StateRoot, we'll probably need to separate out the cursor_factorys into a separate crate
CodSpeed Performance ReportMerging #15760 will improve performances by 11.68%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
DatabaseStateRootinto a regular stateful trait that takes in&self.from_txmethod to a new traitStateRootFromTximplemented byStateRoottx refto the trait implementer (StateRootin this case)resolves: #15478