chore: enable clippy::iter_over_hash_type lints to check where non-determinstic iteration is happening

[kevaundray]

Not intended to fix the lint warnings.

Rationale: Iterating over a HashMap/HashSet is non-deterministic and can cause bugs where one expects determinism. This PR enables the lint to just double check where this non-determinism is happening. Likely okay in all of the places it is happening.

EDIT: CI exits early so would need to run it locally to see all of the errors

[kevaundray]

Sidenote: one nice reason to have as much determinsm as possible is mainly testing -- in particular, one can benefit from snapshot testing the determinstic parts in a "convenient" way using something like insta.rs https://insta.rs

[mattsse]

should we enable this on workspace level in cargo.toml instead?

[kevaundray]

should we enable this on workspace level in cargo.toml instead?

Yep, we could do that -- I think there are likely quite a lot of false positives, ie places where it might be fine to have non-determinism, so I'll need to go through each crate individually and check that we should have determinism and that switching to something like BTreeMap doesn't hurt performance