-
Notifications
You must be signed in to change notification settings - Fork 1.6k
deps: bump libmdbx to 0.13.6 #15412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump libmdbx to 0.13.6 #15412
Conversation
@shekhirin, Please use the |
@erthink I see, we will wait for the 0.13.6, thank you! Do you have any estimates when do you plan to release it? |
The 0.13.6 release is expected to be in 3 weeks, i.e. in April. But if you intend to use the 0.13.x branch, then I recommend not waiting for the next release, but achieving the tests now with the This will avoid discovering some kind of flaws immediately after the release (which just a scheduled in time manner). |
@shekhirin, I just noticed that some cursors operation tests are broken. Since version 0.13, libmdbx has additional checks that prohibit operations with the cursor in a undefined/unpredictable state. Thus a hidden heisenbugs are revealed. -- Actually, of course, cursor(s) behavior are fully deterministic. |
63a9723
to
85fcd03
Compare
1f958b4
to
24c8c1d
Compare
DO NOT MERGE: blocked until we test this PR and Pectra is on mainnet
This bump has breaking changes in cursor behaviour.
seek_exact
didn't find a matching keyreth/crates/storage/db/src/implementation/mdbx/mod.rs
Line 1380 in 85fcd03
reth/crates/storage/db/src/implementation/mdbx/mod.rs
Lines 971 to 975 in 1f958b4
reth/crates/storage/libmdbx-rs/tests/cursor.rs
Lines 330 to 339 in ef69ad0