Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: use with_ prefix for AuthServerConfig setter methods #11882

Closed
wants to merge 1 commit into from

Conversation

tcoratger
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a builder type only we don't necessarily need this prefix,
I usually only add with_ for types that kinda are its own builder

@mattsse mattsse closed this Oct 18, 2024
@tcoratger
Copy link
Contributor Author

since this is a builder type only we don't necessarily need this prefix, I usually only add with_ for types that kinda are its own builder

@mattsse aaah ok I did that because by reading the code I found a with_ prefix here in similar functions

pub fn with_server_config(mut self, config: ServerBuilder<Identity, Identity>) -> Self {

pub fn with_ipc_config(mut self, config: IpcServerBuilder<Identity, Identity>) -> Self {

Is it normal then or should we remove the prefix here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants