Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trie): removing a blinded leaf should result in an error #11869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(trie): removing a blinded leaf should result in an error #11869

wants to merge 1 commit into from

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Oct 18, 2024 •
edited
Loading

reth/crates/trie/sparse/src/trie.rs

Lines 272 to 274 in 21f303f

// If the path wasn't present in `values`, we still need to walk the trie and ensure that
// there is no node at the path. When a leaf node is a blinded `Hash`, it will have an entry
// in `nodes`, but not in the `values`.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Oct 18, 2024
@shekhirin shekhirin marked this pull request as ready for review October 18, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shekhirin