Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to composable executor for Ethereum #11838

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: switch to composable executor for Ethereum #11838

wants to merge 2 commits into from
+279 −1,617

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Oct 17, 2024 •
edited
Loading

Towards #11274

  • Removes module reth_evm_ethereum::execute and renames reth_evm_ethereum::strategy -> reth_evm_ethereum::execute
  • Adds helper type EthExecutorProvider that offers the same API as the old provider type to minimize the impact of the change.
  • Changes to use composable executor types BasicBlockExecutorProvider and EthExecutionStrategyFactory where needed.

Successful executions of hive https://github.com/paradigmxyz/reth/actions/runs/11388193195 and kurtosis https://github.com/paradigmxyz/reth/actions/runs/11388196289

@fgimenez fgimenez added C-enhancement New feature or request A-execution Related to the Execution and EVM labels Oct 17, 2024
@fgimenez fgimenez force-pushed the fgimenez/switch-to-composable-executors-eth branch 2 times, most recently from 57448fb to 9bd8a71 Compare October 17, 2024 14:34
@fgimenez fgimenez force-pushed the fgimenez/switch-to-composable-executors-eth branch from 9bd8a71 to 2f4073b Compare October 17, 2024 15:08
@fgimenez fgimenez marked this pull request as ready for review October 17, 2024 16:05
@fgimenez fgimenez mentioned this pull request Oct 17, 2024
Draft
Rjected
Rjected approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I like the new abstraction / implementation a lot

@Rjected
Copy link
Member

Rjected commented Oct 18, 2024

Let's wait until #11865 is merged to merge this, marking this as blocked for now

@Rjected Rjected added the S-blocked This cannot more forward until something else changes label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgimenez @Rjected