-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace receipt envelope encoded with trait #11742
Open
hoank101
wants to merge
22
commits into
paradigmxyz:main
Choose a base branch
from
hoank101:hoa/first-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 15, 2024
mattsse
requested changes
Oct 15, 2024
mattsse
requested changes
Oct 16, 2024
mattsse
added
C-debt
Refactor of code section that is hard to understand or maintain
A-sdk
Related to reth's use as a library
labels
Oct 16, 2024
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Rjected
requested changes
Oct 16, 2024
what needs to be changed here @Rjected ? I also don't fully know |
I think an let mut payload_len = self.receipt_length();
// account for eip-2718 type prefix and set the list
if !matches!(self.receipt.tx_type, TxType::Legacy) {
// we do NOT include a string header for 2718 envelope encoded receipts, but we do need to include the 2718 type byte
payload_len += 1;
}
payload_len |
# Conflicts: # crates/primitives/src/receipt.rs
Rjected
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nits, otherwise this looks good, thanks for adding the tests!
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #11737